On Thu, Apr 14, 2005 at 05:31:38PM -0700, David Stevens wrote:
>
> > In fact with your patch we can end up calling ip6_flush_pending_frames
> > twice. Granted that it is currently harmless but it isn't nice.
>
> I don't see this. My original patch only calls
> ip6_flush_pending_frames() once, since the original code already only
You called ip6_flush_pending_frames() when rawv6_push_pending_frames
returned an error. However rawv6_push_pending_frames can return an
error that was in turn returned by ip6_push_pending_frames.
As you know ip6_push_pending_frames always frees the cork buffer so
this is tantamount to calling ip6_flush_pending_frames twice.
> I saw that in the code, but I also saw a 2K single skb when the
> MTU is 1500. A piece I looked at appeared to be allocating space for
That's definitely wrong. Please give us a test case (or patch :) so
that this can be fixed.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|