Re: [PATCH] RTNETLINK: Protocol family wildcard dumping for routing rules

[Thomas Graf <tgraf@xxxxxxx>]

* jamal <1112921300.1088.54.camel@xxxxxxxxxxxxxxxx> 2005-04-07 20:48
> Right but if CONFIG_IP_MULTIPLE_TABLES is compiled it will find it in 
> family = PF_INET, no?

Yes if rtgenmsg->rtgen_family is set to PF_IPV4. What I'm trying to
achieve is that if the user specifies PF_UNSPEC that it will look
through all families looking for possible rules to dump, ...

> In the minimal shouldnt you have #ifdef CONFIG_IP_MULTIPLE_TABLES around
> that defined?

...  this may include rule systems that do not depend on
CONFIG_IP_MULTIPLE_TABLES, e.g. IPv6 is likely to get an own config option
for this. Or someday we might have DECnet rules? I don't know.

> I mean why dont you just set it there in that last part where it
> currently fails? i.e set link->dumpit to rtnetlink_dump_all

Because that would interefer with the RTM_GETLINK and RTM_GETNEIGH.
We need that link_rtnetlink_table which is then mapped to PF_UNSPEC
and PF_PACKET protocol family for the wildcard support.