netdev
[Top] [All Lists]

Re: Fwd: atomic_dec_and_test for child dst needed in dst_destroy?

To: pravins@xxxxxxxxxxxxxx (pravin b shelar)
Subject: Re: Fwd: atomic_dec_and_test for child dst needed in dst_destroy?
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 07 Apr 2005 21:23:41 +1000
Cc: christoph@xxxxxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <4253A3A0.800@xxxxxxxxxxxxxx>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
pravin b shelar <pravins@xxxxxxxxxxxxxx> wrote:
>
> This patch  will remove the need for atomic_dec_and_test for this 
> particular case.
> Now we can break down the atomic_dec_and_test to atomic_dec & atomic_read.

Sorry I overlooked your patch.  Otherwise we could have solved this
one day earlier :)

> Please comment.

There is just one problem.  We need an extra barrier before or after
the goto since we no longer have the implicit barrier given by
atomic_dec_and_test.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


<Prev in Thread] Current Thread [Next in Thread>