Re: [PATCH] NETLINK_UESTABLISHED notifier event

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Dmitry Yusupov <dmitry_yus@xxxxxxxxx> wrote:
> 
> * new event for unicast connections NETLINK_UESTABLISHED.

Huh? In the patch you're actually sending the notification
when the socket stops listening to multicast traffic.

Please document why we need this in greater detail too.

> * netlink alloc_skb() now uses sk_allocation instead of hard-coded
> GFP_KERNEL

Why? We never set it to anything else for netlink.

> * since netlink event described via proto and pid,
> netlink_getsockbypid() is exported, so netlink user can identify socket.

Please submit the users for kernel inclusion first.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt