netdev
[Top] [All Lists]

Re: [PATCH] improvement on net/sched/cls_fw.c's hash function

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] improvement on net/sched/cls_fw.c's hash function
From: Wang Jian <lark@xxxxxxxxxxxx>
Date: Tue, 05 Apr 2005 20:39:41 +0800
Cc: netdev@xxxxxxxxxxx, jamal <hadi@xxxxxxxxxx>
In-reply-to: <20050405121605.GM26731@xxxxxxxxxxxxxx>
References: <20050405190024.024D.LARK@xxxxxxxxxxxx> <20050405121605.GM26731@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Hi Thomas Graf,


On Tue, 5 Apr 2005 14:16:05 +0200, Thomas Graf <tgraf@xxxxxxx> wrote:

> 
> What I'm worried about is that we lose the zero collisions behaviour
> for the most popular use case.

If a web interface is used to generate netfilter/tc rules that use
nfmark, then the above assumption is false. nfmark will be used
incrementally and wrapped back to 0 somewhere like process id. So zero
collision is not likely.

When linux's QoS control capability is widely used, such web interface
sooner or later comes into being.
 
> New idea: we make this configureable and allow 3 types of hash functions:
>  1) default as-is, perfect for marks 0..255
>  2) all bits taken into account (your patch)
>  3) bitmask + shift provided by the user just like
>     dsmark.
> 
> Thoughts?

Your suggestion is very considerable. But that needs some more work. And,
isn't that some bloated?


-- 
  lark


<Prev in Thread] Current Thread [Next in Thread>