netdev
[Top] [All Lists]

Re: [PATCH] improvement on net/sched/cls_fw.c's hash function

To: Wang Jian <lark@xxxxxxxxxxxx>
Subject: Re: [PATCH] improvement on net/sched/cls_fw.c's hash function
From: jamal <hadi@xxxxxxxxxx>
Date: 05 Apr 2005 06:25:34 -0400
Cc: netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050405140342.024A.LARK@xxxxxxxxxxxx>
Organization: jamalopolous
References: <20050405133336.0247.LARK@xxxxxxxxxxxx> <20050404223744.1f04c130.davem@xxxxxxxxxxxxx> <20050405140342.024A.LARK@xxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Wang,

I read that thread and i am a little confused. What is this change
supposed to improve?

cheers,
jamal

On Tue, 2005-04-05 at 02:05, Wang Jian wrote:
> Hi David S. Miller,
> 
> New patch attached. Hashsize is 256, the same as old one.
> 
> 
> On Mon, 4 Apr 2005 22:37:44 -0700, "David S. Miller" <davem@xxxxxxxxxxxxx> 
> wrote:
> 
> > On Tue, 05 Apr 2005 13:35:02 +0800
> > Wang Jian <lark@xxxxxxxxxxxx> wrote:
> > 
> > > https://lists.netfilter.org/pipermail/netfilter-devel/2005-March/018762.html
> > > 
> > > I chose 509 for FW_FILTER_HSIZE. If you feel it is waste of memory, then
> > > 251 is good too.
> > 
> > Please us a power of two, the "%" is expensive on some cpus.
> 
> 


<Prev in Thread] Current Thread [Next in Thread>