netdev
[Top] [All Lists]

Re: [PATCH 2/2][AX25] make ax25_queue_xmit a net_device parameter

To: hadi@xxxxxxxxxx
Subject: Re: [PATCH 2/2][AX25] make ax25_queue_xmit a net_device parameter
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Mon, 4 Apr 2005 20:08:39 -0300
Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=eJqEO9seUN4hAcomQRcO6ctk+XHGwEe3AWJVXjbwbSrWvsDFO6MhdWfW4SxowsX4cfwbW6XF6SH6jDWnN8nPOMFkLbNLWd7+ynGEl22IL5r2dQySiMZD3zK2SVMbANUnZUkFhDZ4wE6j7lvUi1xSW+ZAb/r7PnzgS276QUICL6k=
In-reply-to: <1112645495.1078.40.camel@xxxxxxxxxxxxxxxx>
References: <20050404195030.GJ640@xxxxxxxxxxxxxxxx> <1112645495.1078.40.camel@xxxxxxxxxxxxxxxx>
Reply-to: acme@xxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On 04 Apr 2005 16:11:36 -0400, jamal <hadi@xxxxxxxxxx> wrote:
> 
> You probably wanna set skb->input_dev in ax25_type_trans() as well
> something like:
> skb->input_dev = skb->dev = dev

Yup, forgot about this one in this patch, but I want right now is mostly to
reduce open coding all around while maintaining the same behaviour, in
time we can eventually see a better abstraction for this set of operations,
it should also set skb->protocol internally and not return a value to set
skb->protocol, etc. :-)

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>