netdev
[Top] [All Lists]

Re: take 2 WAS(Re: PATCH: IPSEC xfrm events

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: take 2 WAS(Re: PATCH: IPSEC xfrm events
From: jamal <hadi@xxxxxxxxxx>
Date: 03 Apr 2005 10:31:58 -0400
Cc: Patrick McHardy <kaber@xxxxxxxxx>, Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1112469601.1088.173.camel@xxxxxxxxxxxxxxxx>
Organization: jamalopolous
References: <1112319441.1089.83.camel@xxxxxxxxxxxxxxxx> <20050401042106.GA27762@xxxxxxxxxxxxxxxxxxx> <1112353398.1096.116.camel@xxxxxxxxxxxxxxxx> <20050401114258.GA2932@xxxxxxxxxxxxxxxxxxx> <1112358278.1096.160.camel@xxxxxxxxxxxxxxxx> <20050401123554.GA3468@xxxxxxxxxxxxxxxxxxx> <1112403845.1088.14.camel@xxxxxxxxxxxxxxxx> <20050402012813.GA24575@xxxxxxxxxxxxxxxxxxx> <1112406164.1088.54.camel@xxxxxxxxxxxxxxxx> <20050402014619.GB24861@xxxxxxxxxxxxxxxxxxx> <1112469601.1088.173.camel@xxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Small change after some testing.
Herbert havent heard back from you - this looks very palatable in my
opinion with comments below still in effect.

cheers,
jamal

On Sat, 2005-04-02 at 14:20, jamal wrote:

> Ok, heres a general patch first cut i think i got all that was discussed
> in there. ive done some basic 5 minutes tests on.
> Once we have agreement i will pass it on to Masahide-san to do more
> thorough testing.
> Look at the XXX comments in the patch.
> 
> A couple of interesting things:
> 
> 1) Weve discussed this before Herbert and i think you misspoke that
> pfkey delivers to all listerners.
> 
> pfkey Add/del/upd now really do tell all processes about what happened.
> Before pfkey would skip the originating process. So far this doesnt seem
> to be an issue in the basic testing.
> 
> 2) I ended adding a policy_notify to the pfkey manager to make the code
> generic. Interesting thing is i dont think pfkey knows what to do with 
> policy expiration or i am misreading the code.
> I dont see any message type for policy expiration as i do for sa
> expiration. Ive put some hooks and a little noise. I could remove the
> printks - for now they are just place holders.
> 
> cheers,
> jamal

Attachment: ipsec-event-take2-1
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>