netdev
[Top] [All Lists]

Re: [PATCH] skb pcount with MTU discovery

To: John Heffner <jheffner@xxxxxxx>
Subject: Re: [PATCH] skb pcount with MTU discovery
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 3 Apr 2005 05:35:47 +1000
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0504021030120.21013@xxxxxxxxxxxxxx>
References: <E1DHUvP-00050C-00@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0504021030120.21013@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Sat, Apr 02, 2005 at 10:32:32AM -0500, John Heffner wrote:
> On Sat, 2 Apr 2005, Herbert Xu wrote:
> 
> > How about fixing tcp_snd_test directly like this?
> 
> I tried that first, but it caused a panic.  I assumed some other point in
> the code assumed that invariant that if TSO is disabled then tso_segs==1.
> I didn't investigate though.

Do you remember what the panic looked like? Perhaps it was because
tso_segs wasn't set at all?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>