| To: | Eric Dumazet <dada1@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [BUG] overflow in net/ipv4/route.c rt_check_expire() |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Fri, 1 Apr 2005 13:08:32 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <424DB7A1.8090803@xxxxxxxxxxxxx> |
| References: | <42370997.6010302@xxxxxxxxxxxxx> <20050315103253.590c8bfc.davem@xxxxxxxxxxxxx> <42380EC6.60100@xxxxxxxxxxxxx> <20050316140915.0f6b9528.davem@xxxxxxxxxxxxx> <4239E00C.4080309@xxxxxxxxxxxxx> <20050331221352.13695124.davem@xxxxxxxxxxxxx> <424D5D34.4030800@xxxxxxxxxxxxx> <20050401122802.7c71afbc.davem@xxxxxxxxxxxxx> <424DB7A1.8090803@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 01 Apr 2005 23:05:37 +0200 Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote: > You mean you prefer : > > static spinlock_t *rt_hash_lock ; /* rt_hash_lock = > alloc_memory_at_boot_time(...) */ > > instead of > > static spinlock_t rt_hash_lock[RT_HASH_LOCK_SZ] ; > > In both cases, memory is taken from lowmem, and size of kernel image > is roughly the same (bss section takes no space in image) In the former case the kernel image the bootloader has to load is smaller. That's important, believe it or not. It means less TLB entries need to be locked permanently into the MMU on certain platforms. |
| Previous by Date: | [PATCH] skb pcount with MTU discovery, John Heffner |
|---|---|
| Next by Date: | Re: [PATCH] skb pcount with MTU discovery, David S. Miller |
| Previous by Thread: | Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet |
| Next by Thread: | Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet |
| Indexes: | [Date] [Thread] [Top] [All Lists] |