Re: [BUG] overflow in net/ipv4/route.c rt_check

netdev

Re: [BUG] overflow in net/ipv4/route.c rt_check_expire()

To:	Eric Dumazet <dada1@xxxxxxxxxxxxx>
Subject:	Re: [BUG] overflow in net/ipv4/route.c rt_check_expire()
From:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Date:	Thu, 31 Mar 2005 22:13:52 -0800
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<4239E00C.4080309@xxxxxxxxxxxxx>
References:	<42370997.6010302@xxxxxxxxxxxxx> <20050315103253.590c8bfc.davem@xxxxxxxxxxxxx> <42380EC6.60100@xxxxxxxxxxxxx> <20050316140915.0f6b9528.davem@xxxxxxxxxxxxx> <4239E00C.4080309@xxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Thu, 17 Mar 2005 20:52:44 +0100
Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:

>     - Move the spinlocks out of tr_hash_table[] to a fixed size table : Saves 
> a lot of memory (particulary on UP)

If spinlock_t is a zero sized structure on UP, how can this save memory
on UP? :-)

Anyways, I think perhaps you should dynamically allocate this lock table.
Otherwise it looks fine.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] no more rwlock_t inside tcp_ehash_bucket, Eric Dumazet Re: [PATCH] no more rwlock_t inside tcp_ehash_bucket, David S. Miller [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet [PATCH] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures, Eric Dumazet Re: [PATCH] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures, David S. Miller Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), David S. Miller Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), David S. Miller <=

Previous by Date:	Re: RFC: Redirect-Device, Ben Greear
Next by Date:	Re: [IPSEC] Make IPCOMP more resilient, David S. Miller
Previous by Thread:	Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet
Next by Thread:	[PATCH] use NETIF_F_LLTX in bonding device, Arthur Kepner
Indexes:	[Date] [Thread] [Top] [All Lists]