netdev
[Top] [All Lists]

Re: RFC: Redirect-Device

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: RFC: Redirect-Device
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Thu, 31 Mar 2005 14:54:14 -0800
Cc: hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050331143531.30f4eb8f.davem@xxxxxxxxxxxxx>
Organization: Candela Technologies
References: <424C6089.1080507@xxxxxxxxxxxxxxx> <1112303627.1073.71.camel@xxxxxxxxxxxxxxxx> <424C6B10.6030200@xxxxxxxxxxxxxxx> <1112306031.1073.109.camel@xxxxxxxxxxxxxxxx> <424C7813.4000101@xxxxxxxxxxxxxxx> <20050331143531.30f4eb8f.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020
David S. Miller wrote:
On Thu, 31 Mar 2005 14:22:11 -0800
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:


[root@jzny root]# tc
Usage: tc [ OPTIONS ] OBJECT { COMMAND | help }
where  OBJECT := { qdisc | class | filter }
      OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -b[atch] file
}

My personal opinion is that netlink sockets are a pain in the ass to deal
with, and there is no way I want to try to programatically parse the tc
input or output.

And probably not so easy to manipulate from a kernel module.

And BNF cannot be more powerful than a c/c++ program with a byte-buffer
representing the entire ethernet frame.


So you're not even going to give Jamal's suggestion a try?

No.  I can't imagine a way to make it work with my application.

I don't think I can overstate the benefits I see from having
net_devices and their attending standard interfaces
to utilize in both kernel and user-space.

If we have the infrastructure to do what you want, we should use it,
not add "yet another way" to do something we can do already.

If adding some clean abstraction layer helps out your cause, that's
fine too.  We could even hack tc to output things in a format that
you might find easier to parse.

'tc' is very powerful, and very shamefully under-utilizied.  You're task
seems the perfect match for it's use.

I obviously can't force you to accept the redirect module, so
if no one else sees any reason for it, then we can simply
drop the matter and I'll carry it in my own patch set like
I do my other stuff.  No hard feelings, and if someone decides
they could use something like it in the future, then perhaps
we can take another look at it.

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>