Re: RFC: IPSEC patch 0 for netlink events

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Hi Jamal:

On Sun, Mar 27, 2005 at 02:07:29PM -0500, jamal wrote:
>
> @@ -478,6 +491,9 @@
>  
>       if (x1->km.state == XFRM_STATE_ACQ) {
>               __xfrm_state_insert(x);
> +             /* XXXX: We already have xfrm_state_lock
> +              * do we need to grab x->lock as well? */
> +             xfrm_sa_notify(x, c, XFRM_SA_ADDED);

Actually, this shouldn't be here at all.

Calls to xfrm_sa_notify (better to call it km_state_notify for
consistency) should be made from the places where we currently
call pfkey_broadcast and the corresponding locations in xfrm_user.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt