netdev
[Top] [All Lists]

Re: [PATCH] s390: qeth tcp segmentation offload

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] s390: qeth tcp segmentation offload
From: Andrew Morton <akpm@xxxxxxxx>
Date: Mon, 28 Mar 2005 23:09:29 -0800
Cc: linux-kernel@xxxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4248FD8D.6030208@xxxxxxxxx>
References: <200503290533.j2T5X0ZZ028790@xxxxxxxxxxxxxxx> <4248FD8D.6030208@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> Please help me understand:  why add all this TSO code (zerocopy), if you 
>  are adding memcpy() under the hood?
> 
>  Was this reviewed on netdev?  or by any network developer?
> 
>  Overall this patch adds a whole lot of code that must be VERY intimate 
>  with the net stack, a huge maintenance burden that is likely to be rife 
>  with out-of-date code and bugs over time.
> 

There was some dicussion on linux-net last Thursday.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] s390: qeth tcp segmentation offload, Andrew Morton <=