Re: memory leak in net/sched/ipt.c?

[jamal <hadi@xxxxxxxxxx>]

On Wed, 2005-03-23 at 08:23, Thomas Graf wrote:

> 
> kfree simply does nothing if it is given a null pointer so that
> goto rtattr_failure for t == NULL  is handled just fine without
> a check. I will never get used to this behaviour and policy as
> well though, it somewhat makes code less readable.
> 

I cant get used to it either; actually i dont think i would be able 
to stop my fingers ;-> 

> > didnt understand the janitor part.
> 
> It will probably be removed again by one of the regular 'remove
> unnecessary pre kfree checks' patchsets.
> 

Yes, already Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> has made that
point - although he did not post to netdev!! ;->

So ignore my comment Herbert

cheers,
jamal