netdev
[Top] [All Lists]

Re: [PATCH 2.6.11 7/8] tg3: Fix ethtool set functions

To: Michael Chan <mchan@xxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.11 7/8] tg3: Fix ethtool set functions
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 22 Mar 2005 15:59:05 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <B1508D50A0692F42B217C22C02D84972020F3E27@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <B1508D50A0692F42B217C22C02D84972020F3E27@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Michael Chan wrote:
Fix all relevant ethtool set functions to properly handle the
!netif_running() case. In most cases, the new settings are accepted without
setting the hardware if !netif_running(). The new settings will take effect
when the device is subsequently brought up. tg3_nway_reset() is the exception
where it will return -EAGAIN if !netif_running().


Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx

ACK



<Prev in Thread] Current Thread [Next in Thread>