| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [23/*] [IPV4] Kill remaining unnecessary uses of dst_pmtu |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Fri, 18 Mar 2005 20:19:18 +1100 |
| Cc: | Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050318091129.GA28658@xxxxxxxxxxxxxxxxxxx> |
| References: | <20050306213214.7d8a143d.davem@xxxxxxxxxxxxx> <20050307103536.GB7137@xxxxxxxxxxxxxxxxxxx> <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> <20050314102614.GA9610@xxxxxxxxxxxxxxxxxxx> <20050314105313.GA21001@xxxxxxxxxxxxxxxxxxx> <20050314111002.GA29156@xxxxxxxxxxxxxxxxxxx> <20050315091904.GA6256@xxxxxxxxxxxxxxxxxxx> <20050315095837.GA7130@xxxxxxxxxxxxxxxxxxx> <20050318090310.GA28443@xxxxxxxxxxxxxxxxxxx> <20050318091129.GA28658@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
Hi Dave: Once again here is a couple of trivial dst_pmtu/dst_mtu replacements. In both locations, we can only have simple dst entries which means that dst == dst->path. BTW, this is the rule that we should apply in future for uses of dst_mtu/dst_pmtu (or other metrics on dst). If the only dst's that can appear are simple dst's (dst == dst->path), then we should use dst_mtu or dst_metric. If dst != dst->path, then whoever is writing the code will need to think about which of dst or dst->path is the right one. In most instances dst will be the one. However, as we have seen in ip_append_data, dst->path may be needed rarely. In particular, if we're doing fragmentation immediately after IPsec, then you may need it. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| Previous by Date: | [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS, Herbert Xu |
|---|---|
| Next by Date: | Missing hunk in drivers/usb/Makefile, Colin Leroy |
| Previous by Thread: | [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS, Herbert Xu |
| Next by Thread: | [24/*] [IPSEC] Get ttl from child instead of path, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |