netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

[PATCH] net/socket.c : remove redundant NULL pointer check before kfree(

from [Jesper Juhl] [Permanent Link][Original]
To: netdev@xxxxxxxxxxx
Subject: [PATCH] net/socket.c : remove redundant NULL pointer check before kfree()
From: Jesper Juhl <juhl-lkml@xxxxxx>
Date: Thu, 17 Mar 2005 20:34:05 +0100 (CET)
Cc: Orest Zborowski <obz@xxxxxxxxx>, Ross Biro <bir7@xxxxxxxxxxxxxxxxxxx>, "Fred N. van Kempen" <waltje@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx 
kfree() handles NULL pointers just fine, checking first is pointless.


Signed-off-by: Jesper Juhl <juhl-lkml@xxxxxx>

--- linux-2.6.11-mm4-orig/net/socket.c  2005-03-16 15:45:42.000000000 +0100
+++ linux-2.6.11-mm4/net/socket.c       2005-03-17 20:25:36.000000000 +0100
@@ -993,8 +993,7 @@ static int sock_fasync(int fd, struct fi
        sock = SOCKET_I(filp->f_dentry->d_inode);
 
        if ((sk=sock->sk) == NULL) {
-               if (fna)
-                       kfree(fna);
+               kfree(fna);
                return -EINVAL;
        }
 




(Please CC me on replies to lists other than linux-kernel)
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] [NET] Save space for sk_alloc_slab() failure message., David S. Miller
Next by Date:  Re: [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet
Previous by Thread:  [PATCH] [NET] Save space for sk_alloc_slab() failure message., YOSHIFUJI Hideaki / 吉藤英明
Next by Thread:  Re: [PATCH] net/socket.c : remove redundant NULL pointer check before kfree(), David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]