Re: [RFT 1/3] 8139: safer spin loop for get_statistics

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Stephen Hemminger <shemminger@xxxxxxxx> :
[...]
> diff -Nru a/drivers/net/8139cp.c b/drivers/net/8139cp.c
> --- a/drivers/net/8139cp.c    2005-03-16 14:54:48 -08:00
> +++ b/drivers/net/8139cp.c    2005-03-16 14:54:48 -08:00
[...]
> -     while (work-- > 0) {
> +     for (i = 0; i < 1000; i++) {
>               if ((cpr32(StatsAddr) & DumpStats) == 0)
>                       break;
> -             cpu_relax();
> +             udelay(10);
>       }

I am tempted to remove some stuff:

        while (cpr32(StatsAddr) & DumpStats) {
                if (msleep_interruptible(1))
                        break;
        }

May be we could remove "cpr32(StatsAddr);" too as any posted write will
be commited in the loop anyway.

--
Ueimor