netdev
[Top] [All Lists]

Re: [17/*] [NET] Replace dst_pmtu with dst_mtu

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [17/*] [NET] Replace dst_pmtu with dst_mtu
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Tue, 15 Mar 2005 20:02:26 +0100
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, Netfilter Development Mailinglist <netfilter-devel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20050315102450.0f3f1618.davem@xxxxxxxxxxxxx>
References: <20050214221433.GB18465@xxxxxxxxxxxxxxxxxxx> <20050214221607.GC18465@xxxxxxxxxxxxxxxxxxx> <20050306213214.7d8a143d.davem@xxxxxxxxxxxxx> <20050307103536.GB7137@xxxxxxxxxxxxxxxxxxx> <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> <20050314102614.GA9610@xxxxxxxxxxxxxxxxxxx> <20050314105313.GA21001@xxxxxxxxxxxxxxxxxxx> <20050314111002.GA29156@xxxxxxxxxxxxxxxxxxx> <20050315091904.GA6256@xxxxxxxxxxxxxxxxxxx> <20050315095837.GA7130@xxxxxxxxxxxxxxxxxxx> <20050315100522.GA7275@xxxxxxxxxxxxxxxxxxx> <20050315102450.0f3f1618.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
David S. Miller wrote:
On Tue, 15 Mar 2005 21:05:22 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

At this point the only remaining user of dst_pmtu is ipt_REJECT which
will go away either when we use icmp_send in there or when I replace
it with dst_mtu.


Yes, I saw that posting on netfilter-devel where you asked Rusty
why icmp_send() wasn't directly used even though it appears it
should be.

I would prefer to keep it seperately. I have planned to remove xrlim
from ipt_REJECT so it behaves similar for TCP and ICMP. Limits should
then be handled by the limit match. This can't be done if we switch to
icmp_send().

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>