Re: [PATCH] Fix ax25_get

netdev

Re: [PATCH] Fix ax25_get_socket locking

To:	Ralf Baechle DL5RB <ralf@xxxxxxxxxxxxxx>
Subject:	Re: [PATCH] Fix ax25_get_socket locking
From:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Date:	Mon, 14 Mar 2005 21:30:15 -0800
Cc:	netdev@xxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx
In-reply-to:	<20050314083744.GA12765@xxxxxxxxxxxxxx>
References:	<20050314083744.GA12765@xxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Mon, 14 Mar 2005 08:37:44 +0000
Ralf Baechle DL5RB <ralf@xxxxxxxxxxxxxx> wrote:

> In an attempt to return a locked socket ax25_get_socket() was calling
> lock_sock() with a spinlock held, bad idea.  Making matters worse it's
> only user is running in bottom half context resulting in a potencial
> attempt to sleep in bottom half context, so fix the locking there as well.

Looks fine.  Applied, thanks Ralf.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Fix ax25_get_socket locking, Ralf Baechle DL5RB Re: [PATCH] Fix ax25_get_socket locking, David S. Miller <=

Previous by Date:	Re: [NETLINK] Fix multicast bind/autobind race, David S. Miller
Next by Date:	Re: [PATCH] Fix a gcc-3.4 build failure and gcc-3.3 build warnings with TCP_DEBUG disabled in tcp.h, David S. Miller
Previous by Thread:	[PATCH] Fix ax25_get_socket locking, Ralf Baechle DL5RB
Next by Thread:	Resending ethernet packets to direct neighbours, Weber Matthias
Indexes:	[Date] [Thread] [Top] [All Lists]