| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: More IPSEC trouble |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Sat, 12 Mar 2005 03:35:46 +0100 |
| Cc: | Steve Hill <steve@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx> |
| In-reply-to: | <20050312013515.GA17539@xxxxxxxxxxxxxxxxxxx> |
| References: | <E1D9Ymg-0001x0-00@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0503111453320.18067@xxxxxxxxxxxxxx> <42323125.20706@xxxxxxxxx> <20050312013515.GA17539@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1 |
Herbert Xu wrote: Good catch. However let's try to avoid spreading lock/unlock calls around if possible. Since tunnel_check_size only looks at the state to determine whether it's tunnel mode, it doesn't need to hold the lock at all. Agreed, your patch is better. Regards Patrick |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: More IPSEC trouble, Herbert Xu |
|---|---|
| Next by Date: | Re: [RFC INTRO 0/5] H-TCP congestion control, David S. Miller |
| Previous by Thread: | Re: More IPSEC trouble, Herbert Xu |
| Next by Thread: | Re: More IPSEC trouble, Steve Hill |
| Indexes: | [Date] [Thread] [Top] [All Lists] |