| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [11/*] [NET] Move dst_release out of dst->ops->check |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 10 Mar 2005 18:17:50 -0800 |
| Cc: | kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> |
| References: | <20050214221006.GA18415@xxxxxxxxxxxxxxxxxxx> <20050214221200.GA18465@xxxxxxxxxxxxxxxxxxx> <20050214221433.GB18465@xxxxxxxxxxxxxxxxxxx> <20050214221607.GC18465@xxxxxxxxxxxxxxxxxxx> <20050306213214.7d8a143d.davem@xxxxxxxxxxxxx> <20050307103536.GB7137@xxxxxxxxxxxxxxxxxxx> <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 8 Mar 2005 21:27:41 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Mar 07, 2005 at 09:35:36PM +1100, herbert wrote: > > > > Here's the patch to fix those two problems. Yes I know > > my dst_check implementation is lame. I'll come back and > > fix up all the dst_check functions by moving their dst_release > > calls out. It proves that you were right in that IPv6 dst > > leak thread :) > > As promised here is the patch that moves dst_release out of > dst->ops->check. It bloats sk_dst_check/__sk_dst_check slightly > but they're only used in a handful of places so it isn't too bad. > I actually counted, it's about a few hundred bytes. Applied, thanks Herbert. |
| Previous by Date: | Fw: Log full of "ing_filter: fixed ippp2 out ippp2", Andrew Morton |
|---|---|
| Next by Date: | Re: [PATCH] kill ->accept_fastpath hook, David S. Miller |
| Previous by Thread: | Re: [11/*] [NET] Move dst_release out of dst->ops->check, YOSHIFUJI Hideaki / 吉藤英明 |
| Next by Thread: | [12/*] [IPSEC] Handle local_df in IPv4, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |