netdev
[Top] [All Lists]

Re: [PATCH 1/5] r8169: auto detect 32-bit slot

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] r8169: auto detect 32-bit slot
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 9 Mar 2005 15:16:11 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050309230809.GC9502@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20050309112925.7f7900ab@xxxxxxxxxxxxxxxxx> <m17jkgwp6i.fsf@xxxxxx> <20050309214023.GA9502@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050309135530.5c5c80b6@xxxxxxxxxxxxxxxxx> <20050309230809.GC9502@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 10 Mar 2005 00:08:09 +0100
Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:

> Stephen Hemminger <shemminger@xxxxxxxx> :
> [...]
> > I tested on old Celeron with Netgear card.  I could try Amd and/or Xeon
> > if you want.
> 
> If the systems are 64 bit, one would need to know how the driver behaves
> when DAC is forced and:
> 1) the Netgear card is in a 32 bit slot, dma to highmem is enabled and used
> 2) the Netgear card is in a 32 bit slot, dma to highmem is enabled and unused
> 3) the Netgear card is in a 32 bit slot, dma to highmem is disabled
> 4) the Netgear card is in a 64 bit slot, dma to highmem is enabled and used
> 5) the Netgear card is in a 64 bit slot, dma to highmem is enabled and unused
> 6) the Netgear card is in a 64 bit slot, dma to highmem is disabled
> 
> + the content of the Config2 register for 1-6.
> 
> If the amd64 hosts a built-in 8169, add the behavior with highmem disabled or
> enabled + variable amount of memory.
> 
> As it still leaves some archs in the cold + DAC ought not to be dependant
> on the bus width + a few "broken" adapters exist, the patch makes me a bit
> sceptical.

Okay, the motivation was to try and get rid of the module parameter.
I hate to see more parameters, and really don't like it when different drivers
start to do things in different ways.  Don't really have enough background
to know which adapters and arch combinations are broken; so just drop the patch.

<Prev in Thread] Current Thread [Next in Thread>