netdev
[Top] [All Lists]

Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in cas

To: hadi@xxxxxxxxxx
Subject: Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Tue, 08 Mar 2005 09:45:20 -0800
Cc: Patrick McHardy <kaber@xxxxxxxxx>, leo@xxxxxxxxx, Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <1110287626.1043.146.camel@xxxxxxxxxxxxxxxx>
Organization: Candela Technologies
References: <20050305141225.GA5180@xxxxxxxxxxxxxxxxx> <4229D98F.9010008@xxxxxxxxx> <422A0C21.3050709@xxxxxxxxxxxxxxx> <1110199696.1094.1299.camel@xxxxxxxxxxxxxxxx> <Pine.LNX.4.62.0503072034340.5934@xxxxxxxxxxxxxxxxxx> <1110238537.1043.62.camel@xxxxxxxxxxxxxxxx> <422CE983.7060305@xxxxxxxxx> <1110241190.1043.100.camel@xxxxxxxxxxxxxxxx> <422D1E26.1010902@xxxxxxxxx> <1110287626.1043.146.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020
jamal wrote:
On Mon, 2005-03-07 at 22:38, Patrick McHardy wrote:

jamal wrote:

Indeed that looks bad. But wouldnt have helped if we started at 0
either. You need monotonically increasing values to make proper
sense. So i suppose to do proper qos with L2, one must install the prio
qdisc and rewrite the priomap.

One reason more to move it to an optional ebtables target. Or leave it
all to prio + u32. But I guess a CLASSIFY target similar to iptables
could also be useful otherwise.


I think you still want (perhaps the vlan) driver to come up with some
sane defaults. From what i read from bgrear he has arbitrary values.

By default, everything is mapped to priority of zero, but the user can
specify a mapping to any integer they desire.

If you have some suggestions for some defaults better than zero, I'm
willing to consider it.

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>