Re: [11/*] [NET] Move dst_release out of dst->ops->check

netdev

Re: [11/*] [NET] Move dst_release out of dst->ops->check

To:	herbert@xxxxxxxxxxxxxxxxxxx
Subject:	Re: [11/*] [NET] Move dst_release out of dst->ops->check
From:	YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date:	Tue, 08 Mar 2005 06:50:46 -0600 (CST)
Cc:	davem@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to:	<20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx>
Organization:	USAGI Project
References:	<20050306213214.7d8a143d.davem@xxxxxxxxxxxxx> <20050307103536.GB7137@xxxxxxxxxxxxxxxxxxx> <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

In article <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> (at Tue, 8 Mar 2005 
21:27:41 +1100), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> On Mon, Mar 07, 2005 at 09:35:36PM +1100, herbert wrote:
> > 
> > Here's the patch to fix those two problems.  Yes I know
> > my dst_check implementation is lame.  I'll come back and
> > fix up all the dst_check functions by moving their dst_release
> > calls out.  It proves that you were right in that IPv6 dst
> > leak thread :)
> 
> As promised here is the patch that moves dst_release out of
> dst->ops->check.  It bloats sk_dst_check/__sk_dst_check slightly

I agree.

--yoshfuji

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [4/4] [IPSEC] Store MTU at each xfrm_dst, David S. Miller *[9/] [IPSEC] Check dst validity harder in xfrm_bundle_ok*, Herbert Xu* *Re: [9/] [IPSEC] Check dst validity harder in xfrm_bundle_ok*, David S. Miller* *[11/] [NET] Move dst_release out of dst->ops->check*, Herbert Xu* *Re: [11/] [NET] Move dst_release out of dst->ops->check*, YOSHIFUJI Hideaki / 吉藤英明* <= *Re: [11/] [NET] Move dst_release out of dst->ops->check*, David S. Miller* *[12/] [IPSEC] Handle local_df in IPv4*, Herbert Xu* *[13/] [IPV4] Fix room calculation in icmp_send*, Herbert Xu* *[14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, Herbert Xu* *Re: [14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, David S. Miller* *[15/] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data*, Herbert Xu* *[16/] [INET] Take IPsec overhead into account in tunnels*, Herbert Xu* *[17/] [NET] Replace dst_pmtu with dst_mtu*, Herbert Xu* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, David S. Miller* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, Patrick McHardy*

Previous by Date:	*[11/] [NET] Move dst_release out of dst->ops->check*, Herbert Xu*
Next by Date:	Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header], jamal
Previous by Thread:	*[11/] [NET] Move dst_release out of dst->ops->check*, Herbert Xu*
Next by Thread:	*Re: [11/] [NET] Move dst_release out of dst->ops->check*, David S. Miller*
Indexes:	[Date] [Thread] [Top] [All Lists]