netdev
[Top] [All Lists]

Re: [patch 2/3] drivers/net/wireless/prism54/islpci_hotplug: Use the DMA

To: domen@xxxxxxxxxxxx
Subject: Re: [patch 2/3] drivers/net/wireless/prism54/islpci_hotplug: Use the DMA_{64, 32}BIT_MASK constants
From: mcgrof@xxxxxxxxxxxxxxxxxx (Luis R. Rodriguez)
Date: Mon, 7 Mar 2005 12:14:18 -0500
Cc: prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx, tklauser@xxxxxxxxxxx
In-reply-to: <20050306222355.6686C1ED3D@xxxxxxxxxxxxxxxxxxx>
Mail-followup-to: domen@xxxxxxxxxxxx, prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx, tklauser@xxxxxxxxxxx
Organization: Rutgers University Student Linux Users Group
References: <20050306222355.6686C1ED3D@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Sun, Mar 06, 2005 at 11:23:55PM +0100, domen@xxxxxxxxxxxx wrote:
> 
> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
> when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
> 
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxxx>
> Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>
> ---
> 
> 
>  kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN 
> drivers/net/wireless/prism54/islpci_hotplug.c~dma_mask-drivers_net_wireless_prism54_islpci_hotplug
>  drivers/net/wireless/prism54/islpci_hotplug.c
> --- 
> kj/drivers/net/wireless/prism54/islpci_hotplug.c~dma_mask-drivers_net_wireless_prism54_islpci_hotplug
>      2005-03-05 16:12:02.000000000 +0100
> +++ kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c    2005-03-05 
> 16:12:02.000000000 +0100
> @@ -125,7 +125,7 @@ prism54_probe(struct pci_dev *pdev, cons
>       }
>  
>       /* enable PCI DMA */
> -     if (pci_set_dma_mask(pdev, 0xffffffff)) {
> +     if (pci_set_dma_mask(pdev, DMA_32BIT_MASK)) {

Is this 2.4 backward compatible? If not we'll have to add to 2.4 compat
file on prism54.
        
        Luis

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

Attachment: pgpgzYDA7FqDR.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>