Re: [6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sun, Mar 06, 2005 at 09:35:02PM -0800, David S. Miller wrote:
> On Wed, 16 Feb 2005 22:08:42 +1100
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Let's also fix IPsec PMTU storage.  When we get an MTU update for an
> > xfrm_dst, it should be done to the top dst, not the bottom dst.
> > 
> > For example, when we get a need-to-frag message for host C behind
> > a our IPsec peer B, we should be updating the dst entry for C and
> > not B as we do now.
> > 
> > I've removed the boundary checks since the same checks are done
> > in ipv[46]/route.c already.
> 
> Note that sometimes it is better to replace an "unnecessary as
> determined by me" boundary check with a BUG() instead of
> outright removal.  That way you get to test your assertion :)

Point taken.  However, I must say that using BUG() in these
two particular places would be fatal :)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt