netdev
[Top] [All Lists]

Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Mon, 07 Mar 2005 03:30:26 +0100
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050307015943.GA4533@xxxxxxxxxxxxxxxxxxx>
References: <E1D7t0w-0008Qa-00@xxxxxxxxxxxxxxxxxxxxxxxx> <422AF8D0.3010905@xxxxxxxxx> <20050307012458.GA4335@xxxxxxxxxxxxxxxxxxx> <422BB14A.5030302@xxxxxxxxx> <20050307014337.GA4451@xxxxxxxxxxxxxxxxxxx> <422BB477.3040607@xxxxxxxxx> <20050307015943.GA4533@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Herbert Xu wrote:
How about we fix the bundle problem first, and then add the fwmark/tos
stuff? I think fixing the bundle list scalability is probably more
important than having working TOS/fwmark at this point in time.

I agree that it is more important, but I don't see any harm in fixing
the other problem for transport mode first. Fixing the scalability
problem requires a dynamically resized hash, anything static will
lead to different scalability problems with a large number of policies.
The tos/fwmark part looks comparatively small, simply reroute all
packets based on src/dst/fwmark/predicted final tos if they differ.
But since both of this is not done yet, I think it would be better to
fix the smaller problem first.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>