| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 1/3] fix buggy IEEE80211_CRYPT_* selects |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Sun, 06 Mar 2005 13:00:50 -0500 |
| Cc: | Adrian Bunk <bunk@xxxxxxxxx>, akpm@xxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050306090936.GA31890@xxxxxxxxxxxxxxxxxxx> |
| References: | <200503041237.j24Cbb69026470@xxxxxxxxxxxxxxxxxxx> <42289BDF.1080409@xxxxxxxxx> <20050304221014.GJ3327@xxxxxxxxx> <4228DF62.4000205@xxxxxxxxx> <20050304230718.GL3327@xxxxxxxxx> <20050306090936.GA31890@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 |
Herbert Xu wrote: On Sat, Mar 05, 2005 at 12:07:18AM +0100, Adrian Bunk wrote:The way kconfig currently works, you have to ensure that the dependencies of what you select are fulfilled.Yes Adrian's right. In the other places where we select CRYPTO symbols, we always make sure that CRYPTO itself is selected. See net/ipv4/Kconfig for example. I would rather fix Kconfig. If we are selecting X_1 -- which explicitly depends on X -- when Kconfig should automatically select X. It is completely illogical to duplicate a dependency chain each time you wish to select a symbol.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles, Patrick McHardy |
|---|---|
| Next by Date: | ixgb problem, Baruch Even |
| Previous by Thread: | Re: [patch 1/3] fix buggy IEEE80211_CRYPT_* selects, Herbert Xu |
| Next by Thread: | Re: [patch 1/3] fix buggy IEEE80211_CRYPT_* selects, Adrian Bunk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |