| To: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH]: r8169: Expose hardware stats via ethtool |
| From: | Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 05 Mar 2005 13:53:36 +0000 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Jon Mason <jdmason@xxxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <42229B16.6000006@xxxxxxxxxxxxxxx> |
| References: | <42208D83.80803@xxxxxxxxxxxxxxxxxxxx> <20050226181213.GA13230@xxxxxxxxxxxxxxxxxxxxxxxxxx> <42224F76.9000602@xxxxxxxxxxxxxxxxxxxx> <200502272031.12291.jdmason@xxxxxxxxxx> <422288EC.9010502@xxxxxxxxx> <42229B16.6000006@xxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 |
Hello. Ben Greear wrote: Jeff Garzik wrote:Jon Mason wrote:I think I've found a (very hackish) way around the bad stats error. Tested on amd64, and "solves" the problem.Seems to me, we should instead find a way to avoid calling the stats function if !netif_running()Are the stats valid in the hardware if you start it, stop it, and then read them? They don't seem to be. I get the same kind of garbage before starting as I do after I've started and stopped it. Bye, Rich =] -- Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ] "You can't evaluate a man by logic alone." -- McCoy, "I, Mudd", Star Trek |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/1] More ethtool support for sis900, Daniele Venzano |
|---|---|
| Next by Date: | [PATCH 1/3 XFRM]: Fix ICMP tempsel, Patrick McHardy |
| Previous by Thread: | [PATCH 1/1] More ethtool support for sis900, Daniele Venzano |
| Next by Thread: | [PATCH 1/3 XFRM]: Fix ICMP tempsel, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |