| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: netif_rx packet dumping |
| From: | Baruch Even <baruch@xxxxxxxxx> |
| Date: | Thu, 03 Mar 2005 22:14:35 +0000 |
| Cc: | shemminger@xxxxxxxx, rhee@xxxxxxxxxxxx, jheffner@xxxxxxx, Yee-Ting.Li@xxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050303135718.2e1a0170.davem@xxxxxxxxxxxxx> |
| References: | <20050303123811.4d934249@xxxxxxxxxxxxxxxxx> <42278122.6000000@xxxxxxxxx> <20050303133659.0d224e61.davem@xxxxxxxxxxxxx> <42278554.2090902@xxxxxxxxx> <20050303135718.2e1a0170.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Debian Thunderbird 1.0 (X11/20050116) |
David S. Miller wrote: On Thu, 03 Mar 2005 21:44:52 +0000 Baruch Even <baruch@xxxxxxxxx> wrote:The current linked list goes over all the packets, the linked list we add is for the packets that were not SACKed. The idea being that it is a lot faster since there are a lot less packets not SACKed compared to packets already SACKed (or never mentioned in SACKs).If you have a way around this I'd be happy to hear it.I'm sure you can find a way to steal sizeof(void *) from "struct tcp_skb_cb" :-) It is currently 36 bytes on both 32-bit and 64-bit platforms. This means if you can squeeze out 4 bytes (so that it fits in the skb->cb[] 40 byte area), you can fit a pointer in there for the linked list stuff. Stephen has a patch to move some of the extra congestion control data to their own struct, that would free some space for me :-) I'll need to take a look at this again, the original patch actually increased the number of bytes for the cb from 40 to get some extra space. Baruch |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: netif_rx packet dumping, David S. Miller |
|---|---|
| Next by Date: | Re: netif_rx packet dumping, jamal |
| Previous by Thread: | Re: netif_rx packet dumping, David S. Miller |
| Next by Thread: | Re: netif_rx packet dumping, Baruch Even |
| Indexes: | [Date] [Thread] [Top] [All Lists] |