| To: | Matt Mackall <mpm@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Mar 2005 13:00:31 -0800 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, jmoyer@xxxxxxxxxx |
| In-reply-to: | <8.454130102@xxxxxxxxxxx> |
| References: | <7.454130102@xxxxxxxxxxx> <8.454130102@xxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 03 Mar 2005 14:46:32 -0600 Matt Mackall <mpm@xxxxxxxxxxx> wrote: > Packets that have destructors should not be zapped here as that might > produce additional printk warnings via netconsole. > > Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx> Then where will they be freed, eh? :-) This patch adds an SKB leak. Since you've NULL'd out the list, any SKB skipped will never be freed up at all. |
| Previous by Date: | Re: netif_rx packet dumping, David S. Miller |
|---|---|
| Next by Date: | Re: netif_rx packet dumping, Stephen Hemminger |
| Previous by Thread: | [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo, Matt Mackall |
| Next by Thread: | Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |