Re: [PATCH 1/2] r8169: Jumbo Frames mini-increase

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
[...]
> Applies cleanly to linux-2.6.11-rc4-mm1 and tested on amd64

Thanks, I will test it on x86/sparc64.

[...]
> @@ -1576,8 +1577,12 @@ rtl8169_hw_start(struct net_device *dev)
>  
>       RTL_W8(Cfg9346, Cfg9346_Unlock);
>       RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
> -     RTL_W8(EarlyTxThres, EarlyTxThld);
>  
> +     if (dev->mtu < 7400)
> +             RTL_W8(EarlyTxThres, EarlyTxThld);
> +     else
> +             RTL_W8(EarlyTxThres, LargeSendETT);
> +                     

1 - Any objection against ternary operator, say:

        RTL_W8(EarlyTxThres, (dev->mtu < 7400) ? EarlyTxThld : LargeSendETT);

2 - patch includes uneeded tabs on the last added (empty) line.

--
Ueimor