netdev
[Top] [All Lists]

Re: [Lse-tech] Re: A common layer for Accounting packages

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [Lse-tech] Re: A common layer for Accounting packages
From: jamal <hadi@xxxxxxxxxx>
Date: 28 Feb 2005 10:31:33 -0500
Cc: Andrew Morton <akpm@xxxxxxxx>, Guillaume Thouvenin <guillaume.thouvenin@xxxxxxxx>, kaigai@xxxxxxxxxxxxx, marcelo.tosatti@xxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxx>, jlan@xxxxxxx, lse-tech@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, elsa-devel@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20050228142551.GQ31837@xxxxxxxxxxxxxx>
Organization: jamalopolous
References: <4221E548.4000008@xxxxxxxxxxxxx> <20050227140355.GA23055@xxxxxxxxxx> <42227AEA.6050002@xxxxxxxxxxxxx> <1109575236.8549.14.camel@xxxxxxxxxxxxxxxxxxxxxxxx> <20050227233943.6cb89226.akpm@xxxxxxxx> <1109592658.2188.924.camel@xxxxxxxxxxxxxxxx> <20050228132051.GO31837@xxxxxxxxxxxxxx> <1109598010.2188.994.camel@xxxxxxxxxxxxxxxx> <20050228135307.GP31837@xxxxxxxxxxxxxx> <1109599803.2188.1014.camel@xxxxxxxxxxxxxxxx> <20050228142551.GQ31837@xxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2005-02-28 at 09:25, Thomas Graf wrote:
> * jamal <1109599803.2188.1014.camel@xxxxxxxxxxxxxxxx> 2005-02-28 09:10
[..]
> > To justify writting the new code, I am assuming someone has actually sat
> > down and in the minimal stuck their finger in the air
> > and said "yes, there is definetely wind there".
> 
> I did, not for this problem though. The code this idea comes from sends
> batched events 

I would bet the benefit you are seeing has to do with batching rather
than such an optimization flag. Different ballgame.
I relooked at their code snippet, they dont even have skbs built nor
even figured out what sock or PID. That work still needs to be done it
seems in cn_netlink_send(). So probably all they need to do is move the
check in cn_netlink_send() instead. This is assuming they are not
scratching their heads with some realted complexities.

I am gonna disapear for a while; hopefully the original posters have
gathered some ideas from what we discussed.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>