netdev
[Top] [All Lists]

Re: [PATCH]: r8169: Expose hardware stats via ethtool

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH]: r8169: Expose hardware stats via ethtool
From: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>
Date: Sun, 27 Feb 2005 22:53:42 +0000
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, Jon Mason <jdmason@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050226181213.GA13230@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <42208D83.80803@xxxxxxxxxxxxxxxxxxxx> <200502261132.29261.jdmason@xxxxxxxxxx> <4220B9C6.1010106@xxxxxxxxx> <20050226181213.GA13230@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020
Hello.

Thanks for reviewing, Francois, Jon & Jeff!

Francois Romieu wrote:
[snip]
Btw I'd simply remove the 'work' variable and schedule in an interruptible
way until the dump is done.

OK, that will take me a bit longer to code. ;)

BUG() is a bit exagerated imho.

It seems like a pretty good way of avoiding a buffer overrun to me. E.g.: you copy an extra statistic in rtl8169_get_ethtool_stats(), but forget to update the stats length. Is it not better to crash early, than encounter random behaviour later?

I can put an #ifdef RTL8169_DEBUG / #endif around it, if you'd be happier.

Thanks, bye, Rich =]

--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]

"You can't evaluate a man by logic alone."
  -- McCoy, "I, Mudd", Star Trek

<Prev in Thread] Current Thread [Next in Thread>