[Top] [All Lists]

Re: [PATCH]: r8169: Message level support

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH]: r8169: Message level support
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 26 Feb 2005 16:20:43 -0500
Cc: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050226203518.GA14688@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <4220ADA6.2040506@xxxxxxxxxxxxxxxxxxxx> <20050226203518.GA14688@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Francois Romieu wrote:
Jeff, can you send a ack/nack if you disagree with the remarks below ?

Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> :

There seems to be a mixture of drivers using a bitfield and a level. Which is the currently preferred mechanism?

They do not offer exactly the same range. I prefer to keep both as the
module option is not that expensive.

* The preferred mechanism is to have an integer verbosity level 'debug', which is converted using netif_msg_init() into a bitmap.

* PFX should only be used in probe paths. In all other cases, dev->name should be used.

* I strongly agree with the comment "Imho the driver should not poke its nose into the guts of netif_msg_xxx()"


<Prev in Thread] Current Thread [Next in Thread>