|To:||Francois Romieu <romieu@xxxxxxxxxxxxx>|
|Subject:||Re: [PATCH]: r8169: Message level support|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Sat, 26 Feb 2005 16:20:43 -0500|
|Cc:||Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922|
Francois Romieu wrote:
Jeff, can you send a ack/nack if you disagree with the remarks below ? Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> : [...]There seems to be a mixture of drivers using a bitfield and a level. Which is the currently preferred mechanism?They do not offer exactly the same range. I prefer to keep both as the module option is not that expensive.
* The preferred mechanism is to have an integer verbosity level 'debug', which is converted using netif_msg_init() into a bitmap.
* PFX should only be used in probe paths. In all other cases, dev->name should be used.
* I strongly agree with the comment "Imho the driver should not poke its nose into the guts of netif_msg_xxx()"
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH]: r8169: Message level support, Francois Romieu|
|Next by Date:||rp_filter interaction with netfilter SNAT/un-SNAT, Ian! D. Allen|
|Previous by Thread:||Re: [PATCH]: r8169: Message level support, Francois Romieu|
|Next by Thread:||Re: [PATCH]: r8169: Message level support, Richard Dawe|
|Indexes:||[Date] [Thread] [Top] [All Lists]|