netdev
[Top] [All Lists]

Re: [XFRM]: Fix ICMP tempsel

To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [XFRM]: Fix ICMP tempsel
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 20 Feb 2005 18:37:19 +1100
Cc: kaber@xxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050220.155527.54695259.yoshfuji@xxxxxxxxxxxxxx>
References: <4217266F.6090700@xxxxxxxxx> <20050219184351.GB10773@xxxxxxxxxxxxxxxxxxx> <42182082.9060301@xxxxxxxxx> <20050220.155527.54695259.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Sun, Feb 20, 2005 at 03:55:27PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> 
> I didn't this because there are several places which depend on u8.
> If we go this way, we need to fix other places as well. e.g.

Good point.  However, I think it's better to fix things up once when
we cross from user-space to the kernel rather than converting it for
every single packet.

So here we can do something like this.  Please note that this patch
needs to be used with Patrick's earlier work.  Patrick, if you're
OK with it please merge it in with your patch.

By all means give xfrm_selector_fixup a better name :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>