netdev
[Top] [All Lists]

Re: [XFRM]: Fix ICMP tempsel

To: kaber@xxxxxxxxx, davem@xxxxxxxxxxxxx
Subject: Re: [XFRM]: Fix ICMP tempsel
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 19 Feb 2005 21:23:04 +0900 (JST)
Cc: herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4217266F.6090700@xxxxxxxxx>
Organization: USAGI Project
References: <4217266F.6090700@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <4217266F.6090700@xxxxxxxxx> (at Sat, 19 Feb 2005 12:43:43 +0100), 
Patrick McHardy <kaber@xxxxxxxxx> says:

> The selector ports are initialized to fl_ip_sport/fl_ip_dport instead
> of xfrm_flowi_sport(fl)/xfrm_flowi_dport(fl). This is wrong for ICMP,
> type and code should be stored in sport and dport, in struct flowi both
> are contained in fl_ip_sport.

I agree.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>