| To: | "Randy.Dunlap" <rddunlap@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] pktgen: reduce stack usage |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Fri, 18 Feb 2005 18:56:36 -0800 |
| Cc: | robert.olsson@xxxxxxxxx, netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <20050218134219.3f079110.rddunlap@xxxxxxxx> |
| Organization: | Candela Technologies |
| References: | <20050218134219.3f079110.rddunlap@xxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020 |
Randy.Dunlap wrote: (resend) Any comments this time? pktgen: proc_if_write: reduce stack usage (on i386) from 776 to 296 bytes by combining/reusing locals. Since these methods are not in the fast path, and the stack usage is not near 4k, does this really matter? I'm asking more to be educated than to dismiss the changes.... Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] pktgen: reduce stack usage, Randy.Dunlap |
|---|---|
| Next by Date: | Intel and TOE in the news, Jeff Garzik |
| Previous by Thread: | Re: [PATCH] pktgen: reduce stack usage, David S. Miller |
| Next by Thread: | Re: [PATCH] pktgen: reduce stack usage, Randy.Dunlap |
| Indexes: | [Date] [Thread] [Top] [All Lists] |