On 18/feb/05, at 12:20, Herbert Xu wrote:
OK, this happened because we got preempted before sis900_mii_probe
finished setting the sis_priv->mii. Theoretically this can happen
with SMP as well but I suppose the number of SMP machines with sis900
is fairly small.
Anyway, the fix is to make sure that sis900_mii_probe is done before
the device can be opened. This patch does it by moving the setup
after register_netdevice into the netdev init function.
I think the patch is ok, but it will not apply with the latest changes
I sent to Jeff Garzik (see
<http://gkernel.bkbits.net:8080/netdev-2.6/related/drivers/net/
sis900.c?nav=index.html|src/.|src/drivers|src/drivers/net>.
Don't know if this is a problem, since those changes have not yet
reached Linus tree.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Daniele Venzano <webvenza@xxxxxxxxx>
--
Daniele Venzano
http://teg.homeunix.org
|