netdev
[Top] [All Lists]

Re: [IPSEC] Merge xfrm4_bundle_ok/xfrm6_bundle_ok/stale_bundle

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [IPSEC] Merge xfrm4_bundle_ok/xfrm6_bundle_ok/stale_bundle
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 Feb 2005 09:54:42 +1100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050215141743.1010f2e6.davem@xxxxxxxxxxxxx>
References: <20050129123803.GA17390@xxxxxxxxxxxxxxxxxxx> <20050215141743.1010f2e6.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Feb 15, 2005 at 02:17:43PM -0800, David S. Miller wrote:
> On Sat, 29 Jan 2005 23:38:03 +1100
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > This patch merges __xfrm4_bundle_ok/__xfrm6_bundle_ok/stale_bundle
> > so that when I add MTU verification code I don't have to put it in
> > three places.
> > 
> > It also moves the tests on dst->dev and dst->obsolete outside the
> > loop since the former is identical throughout the bundle and the
> > latter can only be positive on the final element which also happens
> > to be dst->path.
> > 
> > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> 
> Applied to my 2.6.12-pending tree.  Thanks a lot.

Sorry Dave, but that patch has a critical error in stale_bundle
where I forgot to add an exclamation mark.

I've resent the corrected patch in the thread containing the other
MTU patches.  Here it is again.


This patch merges xfrm4_bundle_ok/xfrm6_bundle_ok/stale_bundle
so that later additions for MTU calculation only need to be done once.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: xfrm-1
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>