netdev
[Top] [All Lists]

Re: [RFC][PATCH 2/3] netlink check sender, audit

To: Chris Wright <chrisw@xxxxxxxx>
Subject: Re: [RFC][PATCH 2/3] netlink check sender, audit
From: Pablo Neira <pablo@xxxxxxxxxxx>
Date: Tue, 15 Feb 2005 23:27:48 +0100
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, sds@xxxxxxxxxxxxxx, serue@xxxxxxxxxx
In-reply-to: <20050215222246.GI15867@xxxxxxxxxxxxxxxxxxx>
References: <20050212010109.V24171@xxxxxxxxxxxxxxxxxx> <20050212010243.W24171@xxxxxxxxxxxxxxxxxx> <20050212010504.X24171@xxxxxxxxxxxxxxxxxx> <420E334B.8060805@xxxxxxxxxxx> <420E77FA.6080007@xxxxxxxxxxx> <20050215001334.GB27645@xxxxxxxxxxxxxxxxxxx> <42115E7E.6050909@xxxxxxxxxxx> <20050215034708.GG27645@xxxxxxxxxxxxxxxxxxx> <4212757D.5070401@xxxxxxxxxxx> <20050215222246.GI15867@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
Chris Wright wrote:

* Pablo Neira (pablo@xxxxxxxxxxx) wrote:
I agree, maybe something like the example patch attached. Hope that helps.

This is better, but...

-netlink_kernel_create(int unit, void (*input)(struct sock *sk, int len))
+netlink_kernel_create(int unit, struct netlink_ops *nlops)

...this is exported interface, so would probably require a new function.

I was aware of that. Actually I think that we can modify all calls to netlink_kernel_create (that aren't that much) to fit the new interface, I can post a patch to do that. I prefer providing just one function to create a netlink socket in kernel space.

--
Pablo

<Prev in Thread] Current Thread [Next in Thread>