| To: | Amit Gud <amitg@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [KJ] [PATCH 9/18] drivers/net/ remove pci_find_{device, subsys} |
| From: | Greg KH <greg@xxxxxxxxx> |
| Date: | Mon, 14 Feb 2005 10:46:15 -0800 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxx, gud@xxxxxxx |
| In-reply-to: | <200502141125.25185.amitg@xxxxxxxxxxxxxx> |
| References: | <200502141125.25185.amitg@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6i |
On Mon, Feb 14, 2005 at 11:25:23AM +0530, Amit Gud wrote:
> diff -uprN orig/drivers/net/gt96100eth.c
> linux-2.6.11-rc3/drivers/net/gt96100eth.c
> --- orig/drivers/net/gt96100eth.c 2005-02-11 15:19:48.000000000 +0530
> +++ linux-2.6.11-rc3/drivers/net/gt96100eth.c 2005-02-14 02:07:09.000000000
> +0530
> @@ -615,9 +615,9 @@ static int gt96100_init_module(void)
> /*
> * Stupid probe because this really isn't a PCI device
> */
> - if (!(pci = pci_find_device(PCI_VENDOR_ID_MARVELL,
> + if (!(pci = pci_get_device(PCI_VENDOR_ID_MARVELL,
> PCI_DEVICE_ID_MARVELL_GT96100, NULL)) &&
> - !(pci = pci_find_device(PCI_VENDOR_ID_MARVELL,
> + !(pci = pci_get_device(PCI_VENDOR_ID_MARVELL,
> PCI_DEVICE_ID_MARVELL_GT96100A, NULL))) {
> printk(KERN_ERR __FILE__ ": GT96100 not found!\n");
> return -ENODEV;
This (and many other parts of this patch) are incorrect. Please do not
apply.
thanks,
greg k-h
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 9/18] drivers/net/ remove pci_find_{device, subsys}, Amit Gud |
|---|---|
| Next by Date: | Re: [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing when the device is closed, Francois Romieu |
| Previous by Thread: | [PATCH 9/18] drivers/net/ remove pci_find_{device, subsys}, Amit Gud |
| Next by Thread: | Re: [PATCH 9/18] drivers/net/ remove pci_find_{device, subsys}, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |