netdev
[Top] [All Lists]

Re: [PATCH] arp_queue: serializing unlink + kfree_skb

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] arp_queue: serializing unlink + kfree_skb
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 10 Feb 2005 19:46:57 -0800
Cc: wa@xxxxxxxxxxxxxxx, anton@xxxxxxxxx, okir@xxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20050210045647.GA15552@xxxxxxxxxxxxxxxxxxx>
References: <20050131102920.GC4170@xxxxxxx> <E1CvZo6-0001Bz-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050203142705.GA11318@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050203150821.2321130b.davem@xxxxxxxxxxxxx> <20050204113305.GA12764@xxxxxxxxxxxxxxxxxxx> <20050204154855.79340cdb.davem@xxxxxxxxxxxxx> <20050204222428.1a13a482.davem@xxxxxxxxxxxxx> <20050210012304.E25338@xxxxxxxxxxxxxxx> <20050210045647.GA15552@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 10 Feb 2005 15:56:47 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> > ? If yes, is this a good idea ?
> 
> Dave mentioned that on sparc64, atomic_inc_and_test is much more
> expensive than the second variant.

Actually, besides the memory barriers themselves, all variants
are equally expensive.

On old i386 chips, the test variants are indeed more expensive.
Linus told me this and there is a note about this in the
atomic_ops.txt file if you look at the current copy :-)


<Prev in Thread] Current Thread [Next in Thread>