Re: [Bonding-devel] Re: [Bugme-new] [Bug 4189] New: IPv6 link local addresses are not assigned correctly on multiple-bonding enviromrnts

[Jay Vosburgh <fubar@xxxxxxxxxx>]

David S. Miller <davem@xxxxxxxxxxxxx> wrote:

>On Thu, 10 Feb 2005 10:17:06 -0800
>Jay Vosburgh <fubar@xxxxxxxxxx> wrote:
>
>>      The model used by the bridge device is probably a better way to
>> go, particularly given that IPv6 link local addresses are created at
>> "ifconfig up" time.
>
>IPv6 should catch an event when MAC addresses change, to reassign
>to correct link local address.  I don't think the bonding driver
>needs to change at all.

        Except that most of the bonding internal MAC changes won't
generate any events (presuming you mean a NETDEV_CHANGEADDR).  The
bonding driver calls the slave's dev->set_mac_address directly; the
NETDEV_CHANGEADDR is generated by dev_ifsioc() (which isn't exported).
Now that I'm looking for it, there are some other cases of bonding
calling other dev->functions directly, e.g., change_mtu, that have
wrappers that generate events; I need to fix that.

        Would you have a problem with putting the SIOCSIFHWADDR code
from dev_ifsioc() into a separate exported function, similarly to how
dev_set_mtu() is done?  I can probably whip that up along with the
appropriate bonding changes this evening.

        -J

---
        -Jay Vosburgh, IBM Linux Technology Center, fubar@xxxxxxxxxx