netdev
[Top] [All Lists]

Re: serious netpoll bug w/NAPI

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: serious netpoll bug w/NAPI
From: Martin Josefsson <gandalf@xxxxxxxxxxxxxx>
Date: Thu, 10 Feb 2005 10:16:08 +0100 (CET)
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, jmoyer@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050210011104.GF2366@xxxxxxxxx>
References: <20050208201634.03074349.davem@xxxxxxxxxxxxx> <20050209183219.GA2366@xxxxxxxxx> <20050209164658.409f8950.davem@xxxxxxxxxxxxx> <20050210011104.GF2366@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 9 Feb 2005, Matt Mackall wrote:

> --- mm1npc.orig/net/core/dev.c        2005-02-09 14:15:11.236086000 -0800
> +++ mm1npc/net/core/dev.c     2005-02-09 14:15:13.710042000 -0800
> @@ -1772,6 +1772,7 @@
>
>               dev = list_entry(queue->poll_list.next,
>                                struct net_device, poll_list);
> +             netpoll_poll_lock(dev);
>
>               if (dev->quota <= 0 || dev->poll(dev, &budget)) {
>                       local_irq_disable();
> @@ -1782,9 +1783,11 @@
>                       else
>                               dev->quota = dev->weight;
>               } else {
> +                     netpoll_poll_unlock(dev);
>                       dev_put(dev);
>                       local_irq_disable();
>               }
> +             netpoll_poll_unlock(dev);
>
>  #ifdef CONFIG_KGDBOE
>               kgdb_process_breakpoint();

Double unlock?

/Martin

<Prev in Thread] Current Thread [Next in Thread>