netdev
[Top] [All Lists]

patch: annoying u32 double listing

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: patch: annoying u32 double listing
From: jamal <hadi@xxxxxxxxxx>
Date: 06 Feb 2005 14:49:04 -0500
Cc: netdev@xxxxxxxxxxx
Organization: jamalopolous
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
bug is around since 2.1.x; never cared about chasing it until now
because it is affecting someone i know.
Dave, please apply. I will prepare a 2.4.x version.

To see the problem:

tc qdisc add dev eth0 ingress
#add two filters at different prio levels
tc filter add dev eth0 parent ffff: protocol ip prio 6 \
u32 match ip src 10.0.0.210/32 flowid 1:16
#
tc filter add dev eth0 parent ffff: protocol ip prio 7 \
u32 match ip src 10.0.0.144/32 flowid 1:15 
#now list them..
root@jdev:/# tc -s filter show parent ffff: dev eth0 

filter protocol ip pref 6 u32 
filter protocol ip pref 6 u32 fh 801: ht divisor 1 
filter protocol ip pref 6 u32 fh 801::800 order 2048 key ht 801 bkt 0
flowid 1:15 
  match 0a000090/ffffffff at 12
filter protocol ip pref 6 u32 fh 800: ht divisor 1 
filter protocol ip pref 6 u32 fh 800::800 order 2048 key ht 800 bkt 0
flowid 1:16 
  match 0a0000d2/ffffffff at 12
filter protocol ip pref 7 u32 
filter protocol ip pref 7 u32 fh 801: ht divisor 1 
filter protocol ip pref 7 u32 fh 801::800 order 2048 key ht 801 bkt 0
flowid 1:15 
  match 0a000090/ffffffff at 12
filter protocol ip pref 7 u32 fh 800: ht divisor 1 
filter protocol ip pref 7 u32 fh 800::800 order 2048 key ht 800 bkt 0
flowid 1:16 
  match 0a0000d2/ffffffff at 12

each filter is listed in each priority. So if you had 5 rules in 5 prios
(which is where sherlock started) you see 25 outputs.

AFTER FIX: 
---------

root@jdev:/usr/src# tc -s filter show parent ffff: dev eth0
filter protocol ip pref 6 u32
filter protocol ip pref 6 u32 fh 800::800 order 2048 key ht 800 bkt 0
flowid 1:16  
  match 0a0000d2/ffffffff at 12 
  filter protocol ip pref 7 u32
  filter protocol ip pref 7 u32 fh 801::800 order 2048 key ht 801 bkt 0
flowid 1:15  
    match 0a000090/ffffffff at 12 


cheers,
jamal

Attachment: u32multi_p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>