Re: [patch 2/2] ipvs deadlock fix

[Horms <horms@xxxxxxxxxxxx>]

On Mon, Jan 31, 2005 at 01:47:22AM -0800, Andrew Morton wrote:
> Horms <horms@xxxxxxxxxxxx> wrote:
> >
> > On Sun, Jan 30, 2005 at 10:33:02PM -0800, akpm@xxxxxxxx wrote:
> >  > 
> >  > 
> >  > update_defense_level() is calling si_meminfo() from timer context.  But
> >  > si_meminfo takes non-irq-safe locks.
> >  > 
> >  > Move it all to keventd context.  
> > 
> >  Would I be right in thinking that the offending lock is bdev_lock which
> >  is grabbed in nr_blockdev_pages() and thus that this is not an issue
> >  for 2.4 whose si_meminfo() does not have such a call?
> 
> Yes, 2.4's si_meminfo() seems to be OK from interrupt context.

Thanks.

> On x86 - I didn't check the other architectures.

Me neither.

-- 
Horms