netdev
[Top] [All Lists]

Re: 2.4.29, e100 and a WOL packet causes keventd going mad

To: sfeldma@xxxxxxxxx
Subject: Re: 2.4.29, e100 and a WOL packet causes keventd going mad
From: Nigel Cunningham <ncunningham@xxxxxxxxxxxxx>
Date: Mon, 31 Jan 2005 20:08:03 +1100
Cc: David Härdeman <david@xxxxxxxx>, Michael Gernoth <simigern@xxxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1107152056.21273.56.camel@xxxxxxxxxxxxxxxxxxx>
References: <20050130171849.GA3354@xxxxxxxxxxx> <1107143255.18167.428.camel@xxxxxxxxxxxxxxxxxxxxx> <1107143905.21273.33.camel@xxxxxxxxxxxxxxxxxxx> <1107147615.18167.433.camel@xxxxxxxxxxxxxxxxxxxxx> <1107152056.21273.56.camel@xxxxxxxxxxxxxxxxxxx>
Reply-to: ncunningham@xxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Hi again.

Ignore that :> I realised later that there's only one badly named
routine and my assumption that there was another called disable_.. was
wrong :>

Nigel

On Mon, 2005-01-31 at 17:14, Nigel Cunningham wrote:
> Hi.
> 
> On Mon, 2005-01-31 at 16:00, Scott Feldman wrote:
> > On Sun, 2005-01-30 at 19:58, Nigel Cunningham wrote:
> > > Do you also disable the WOL event when resuming?
> > 
> > Good catch.  How's this look?
> 
> I looked at it last week because I used it for an example of device
> model drivers at the CELF conference. I got your intel address from the
> top of the .c file, but IIRC it bounced. Providence :>
> 
> [...]
> 
> > @@ -2333,6 +2331,7 @@ static int e100_resume(struct pci_dev *p
> >     struct nic *nic = netdev_priv(netdev);
> >  
> >     pci_set_power_state(pdev, PCI_D0);
> > +   pci_enable_wake(pdev, PCI_D0, 0);
> >     pci_restore_state(pdev);
> >     e100_hw_init(nic);
> 
> Shouldn't this be disable_wake?
> 
> Regards,
> 
> Nigel
-- 
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com

Ph: +61 (2) 6292 8028      Mob: +61 (417) 100 574


<Prev in Thread] Current Thread [Next in Thread>